[AMQP] Update Sync Transport to Use Socket Connection API #38966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - eventhub - tests |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - eventhub - perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
l0lawrence
reviewed
Jan 2, 2025
| @@ -190,7 +190,11 @@ def connect(self): | |||
| # are we already connected? | |||
| if self.connected: | |||
| return | |||
| self._connect(self.host, self.port, self.connect_timeout) | |||
There was a problem hiding this comment.
why were we using _connect before?
There was a problem hiding this comment.
the helper method create_connection does the same thing as what _connect was doing https://github.com/python/cpython/blob/fa6c48e4b3d5b6f80a9aed07d4a5620bf62f195f/Lib/socket.py#L822
|
/azp run python - servicebus - tests |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
swathipil
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update the connect code to use the new socket helper method to create a socket connection