JSONL stream #39478
Open
JSONL stream #39478
+863
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
approved these changes
Feb 3, 2025
pvaneck
reviewed
Feb 3, 2025
kristapratico
requested review from
lmazuel,
annatisch and
johanste
as code owners
johanste
reviewed
Feb 5, 2025
|
|
||
| if decoder is not None: | ||
| self._decoder = decoder | ||
| elif self._response.headers.get("Content-Type", "").lower() == "application/jsonl": |
There was a problem hiding this comment.
This would fail if the service provided any parameters in the MIME type. Should we make the decoder a required parameter?
There was a problem hiding this comment.
You're right - making it required. The generated code should know which flavor of decoder to pass, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38806
Implements the design described in https://gist.github.com/kristapratico/d330af39962ea05b10384b865e37b36f
PR adds types for JSONL streaming, SSE will come later.