Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converter from AI Service threads/runs to evaluator-compatible schema #40047
Converter from AI Service threads/runs to evaluator-compatible schema #40047
Changes from all commits
03af2ba
e24d77f
73e3939
c53b72f
149a4cc
8d87168
b3f5ef2
465c1c7
5219616
eed1375
3758eae
c33e4f7
1741980
55294ae
a30abdf
7ec8c35
50e819f
7637357
8bb6cd3
6deb358
cc8df22
85def50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newer APIs use "developer" here (they're essentially interchangeable, just depends on API version). So might want to make sure that's supported too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, didn't know that. What API version should we be bound to or set it to developer by default? I'll look into versioning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for output, we can just use system, at least for now. But when reading in messages from threads/etc., you might need to cover the case where it could say "developer". Or maybe we just default to use whatever the thread itself is using, actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, for this converter's purpose I don't think it matters. I take it back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's write
system
for now—I was thinking of possibly capturing the model it ran on, so if it were o1, we could mark the instructions as coming fromdeveloper
. The thread itself only gives usinstructions
without an explicit marking for either.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, it can be a quick follown so we don't need to be blocked, but I've suggested we include
name
in order to support multi-agent flows. Any objections? @singankit ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can user provide a name ? I do not see it being generated right now by service.