Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-Singleton-Test #40148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix-Singleton-Test #40148

wants to merge 1 commit into from

Conversation

w-javed
Copy link
Contributor

@w-javed w-javed commented Mar 19, 2025

No description provided.

@Copilot Copilot bot review requested due to automatic review settings March 19, 2025 21:10
@w-javed w-javed requested a review from a team as a code owner March 19, 2025 21:10
Copilot
Copilot AI reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the singleton evaluation test behavior.

  • Removed the skip decorator from the evaluate test.
Files not reviewed (1)
  • sdk/evaluation/azure-ai-evaluation/assets.json: Language not supported
Comments suppressed due to low confidence (1)

sdk/evaluation/azure-ai-evaluation/tests/e2etests/test_mass_evaluate.py:87

  • The removal of the skip condition may allow the test to run in playback mode, which could trigger known issues mentioned in the test comment.
-    @pytest.mark.skipif(not is_live(), reason="Skip in playback due to inconsistency in evaluation results.")

@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Mar 19, 2025
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Evaluation Issues related to the client library for Azure AI Evaluation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@w-javed @azure-sdk