Update binarization to be individual params #40168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove required keys
github-actions
bot
added
the
Evaluation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors evaluators to accept individual threshold parameters instead of using a single dictionary-based threshold, improving parameter clarity and type safety.
- Updated QAEvaluator to have separate parameters for groundedness, relevance, coherence, fluency, similarity, and f1_score thresholds.
- Updated ContentSafetyEvaluator to accept individual thresholds for violence, sexual content, self-harm, and hate/unfairness evaluations.
- Updated RougeScoreEvaluator, sample usage, and tests to use individual threshold parameters.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_qa/_qa.py | Replaced dictionary-based thresholds with individual parameters and updated type checking. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_content_safety/_content_safety.py | Modified threshold parameter to individual thresholds with type checking for int. |
| sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_rouge/_rouge.py | Updated threshold parameters to individual floats with corresponding type checks. |
| sdk/evaluation/azure-ai-evaluation/samples/evaluation_samples_threshold.py | Updated usage examples for QAEvaluator and RougeScoreEvaluator to reflect individual thresholds. |
| sdk/evaluation/azure-ai-evaluation/tests/unittests/test_evaluators/test_threshold_behavior.py | Updated tests to use individual threshold parameters instead of dictionaries. |
Comments suppressed due to low confidence (1)
sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_qa/_qa.py:82
- Consider enforcing a stricter type check for 'f1_score_threshold' (e.g., ensure it is a float) rather than accepting an int, to be consistent with its documented type.
for name, value in [
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
w-javed
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines