Sync eng/common directory with azure-sdk-tools for PR 10099 #40169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azure-sdk
added
EngSys
There was a problem hiding this comment.
Pull Request Overview
This PR syncs the eng/common directory with the azure-sdk-tools repository for PR #10099, updating the deployment resource configuration.
- Added the SelfContainedPostScript parameter to pass PersistOidcToken to the deployment script.
- Introduced a conditional task that refreshes the token when PersistOidcToken is true to handle long-running ARM deployments.
Files not reviewed (1)
- eng/common/TestResources/New-TestResources.ps1: Language not supported
| condition: ne($(SELF_CONTAINED_TEST_RESOURCES_POST_SCRIPT), '') | ||
| env: | ||
| ARM_OIDC_TOKEN: $(ARM_OIDC_TOKEN) | ||
| ${{ insert }}: ${{ parameters.EnvVars }} |
There was a problem hiding this comment.
The key '${{ insert }}' in the environment block appears to be a placeholder. Consider replacing it with the intended environment variable name.
Suggested change
| ${{ insert }}: ${{ parameters.EnvVars }} | |
| ENV_VARS: ${{ parameters.EnvVars }} |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
azure-sdk
force-pushed
the
sync-eng/common-benbp/post-script-separate-10099
branch
2 times, most recently
from
79a22c4 to
d8f4f8a
Compare
azure-sdk
force-pushed
the
sync-eng/common-benbp/post-script-separate-10099
branch
from
d8f4f8a to
572b3ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#10099 See eng/common workflow