Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target mar preview test #40172

Merged
merged 2 commits into from
Mar 24, 2025
Merged

target mar preview test #40172

merged 2 commits into from
Mar 24, 2025

Conversation

kristapratico
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kristapratico kristapratico changed the title march preview test preview test Mar 21, 2025
@kristapratico
Copy link
Member Author

/azp run python - openai - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kristapratico
Copy link
Member Author

/azp run python - openai - tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kristapratico kristapratico changed the title preview test target mar preview test Mar 24, 2025
@kristapratico kristapratico marked this pull request as ready for review March 24, 2025 22:13
@Copilot Copilot bot review requested due to automatic review settings March 24, 2025 22:13
@kristapratico kristapratico requested a review from glecaros as a code owner March 24, 2025 22:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the test suite for the SDK to use a new preview API version and adds inline assertions to validate the properties of newly created vector stores, while also updating the file deletion reference to use the correct variable.

  • Updated the PREVIEW version string in tests.
  • Added direct validation of vector store properties in both synchronous and asynchronous tests.
  • Changed file deletion references from file.id to vector_store_file.id in tests.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk/openai/azure-openai/tests/conftest.py Updated the preview API version string for tests
sdk/openai/azure-openai/tests/test_vector_stores.py Added inline assertions for vector store properties and updated file deletion reference
sdk/openai/azure-openai/tests/test_vector_stores_async.py Synchronized the changes with the synchronous tests regarding assertions and file deletion
@kristapratico kristapratico merged commit 339fdc5 into main Mar 24, 2025
25 checks passed
@kristapratico kristapratico deleted the kristapratico-patch-13 branch March 24, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants