[core] add is_sdk_model check and tests#41445
Merged
iscai-msft merged 9 commits intoAzure:mainfrom Jun 11, 2025
Merged
Conversation
iscai-msft
requested review from
annatisch,
johanste,
kashifkhan,
lmazuel,
pvaneck and
xiangyan99
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new function, is_sdk_model, to help determine if an object qualifies as an SDK model.
- Introduces the is_sdk_model function with a clear docstring outlining its purpose
- Implements a check for either a "_is_model" attribute or "_attribute_map" presence to signal an SDK model
Comments suppressed due to low confidence (1)
sdk/core/azure-core/azure/core/serialization.py:133
- [nitpick] The docstring for 'is_sdk_model' uses ':type obj: any' which might be clearer if it matches the function's type annotation (i.e., using 'Any' with proper casing) for consistency.
def is_sdk_model(obj: Any) -> bool:
iscai-msft
commented
Jun 5, 2025
added 4 commits
June 6, 2025 15:32
kristapratico
approved these changes
Jun 10, 2025
pvaneck
approved these changes
Jun 10, 2025
Contributor
Author
|
/check-enforcer override |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #41438