Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] containerservice/resource-manager #5009

Merged
merged 7 commits into from
May 3, 2019

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: containerservice/resource-manager

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Apr 30, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-containerservice

You can install the package azure-mgmt-containerservice of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_containerservice/resource-manager#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_containerservice/resource-manager#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_containerservice/resource-manager
  • pip install -e ./azure-mgmt-containerservice

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_containerservice/resource-manager
  • pip wheel --no-deps ./azure-mgmt-containerservice

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Apr 30, 2019

Codecov Report

Merging #5009 into master will decrease coverage by 0.02%.
The diff coverage is 44.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5009      +/-   ##
==========================================
- Coverage   49.16%   49.13%   -0.03%     
==========================================
  Files        6456     6486      +30     
  Lines      181146   182098     +952     
==========================================
+ Hits        89055    89478     +423     
- Misses      92091    92620     +529
Impacted Files Coverage Δ
.../mgmt/containerservice/container_service_client.py 47.52% <0%> (-3.01%) ⬇️
..._07_01/operations/container_services_operations.py 80.62% <0%> (ø) ⬆️
...ontainerservice/v2019_04_30/operations/__init__.py 100% <100%> (ø) ⬆️
...019_04_30/models/container_service_client_enums.py 100% <100%> (ø) ⬆️
...azure/mgmt/containerservice/v2019_04_30/version.py 100% <100%> (ø) ⬆️
...19_04_30/operations/managed_clusters_operations.py 13.14% <13.14%> (ø)
...e/v2019_04_30/operations/agent_pools_operations.py 17.27% <17.27%> (ø)
...rservice/v2019_04_30/models/managed_cluster_py3.py 21.73% <21.73%> (ø)
...tainerservice/v2019_04_30/models/agent_pool_py3.py 26.31% <26.31%> (ø)
...naged_cluster_agent_pool_profile_properties_py3.py 26.31% <26.31%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e70b965...c0d3cbf. Read the comment docs.

Revert node public ip support from 2019-04-01 model.
@zqingqing1
Copy link
Member

there should be a folder for 2019-04-01, no?

@mboersma
Copy link
Member

mboersma commented May 2, 2019

We don't see the changes here that should have been created by Azure/azure-rest-api-specs#5819, specifically the isPreview addition.

@zqingqing1
Copy link
Member

weird, why there is no python SDK generated?

@lmazuel lmazuel merged commit 44bc675 into master May 3, 2019
@lmazuel lmazuel deleted the restapi_auto_containerservice/resource-manager branch May 3, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants