StreamingRetry #5785
Merged
StreamingRetry #5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
bryevdv
reviewed
Jun 10, 2019
bryevdv
reviewed
Jun 10, 2019
bryevdv
reviewed
Jun 10, 2019
bryevdv
reviewed
Jun 10, 2019
bryevdv
reviewed
Jun 10, 2019
sdk/core/azure-core/azure/core/pipeline/transport/requests_asyncio.py
Outdated
Show resolved
Hide resolved
rajivnandivada
pushed a commit
to rajivnandivada/azure-sdk-for-python
that referenced
this pull request
Jul 3, 2019
* StreamingRetry * add sleep * update per the review feedback
vbarbaresi
added a commit
to vbarbaresi/azure-sdk-for-python
that referenced
this pull request
Oct 8, 2020
This looks like it was a typo introduced in Azure#5785 (review) The review comment makes me think the author meant 1 second, but maybe thought it was milliseconds. time.sleep and asyncio.sleep arguments are both in seconds in Azure#14067 we are experiencing timeouts after ~15 to 16 min (matching 1000 seconds) that are not solved by configuring timeouts in the client
xiangyan99
pushed a commit
that referenced
this pull request
Nov 9, 2020
* fix retry_interval: set it to 1 second instead of 1000 seconds This looks like it was a typo introduced in #5785 (review) The review comment makes me think the author meant 1 second, but maybe thought it was milliseconds. time.sleep and asyncio.sleep arguments are both in seconds in #14067 we are experiencing timeouts after ~15 to 16 min (matching 1000 seconds) that are not solved by configuring timeouts in the client * fix another hardcoded trio.sleep(1000)
nffdiogosilva
pushed a commit
to nffdiogosilva/azure-core
that referenced
this pull request
Oct 17, 2022
* fix retry_interval: set it to 1 second instead of 1000 seconds This looks like it was a typo introduced in Azure/azure-sdk-for-python#5785 (review) The review comment makes me think the author meant 1 second, but maybe thought it was milliseconds. time.sleep and asyncio.sleep arguments are both in seconds in #14067 we are experiencing timeouts after ~15 to 16 min (matching 1000 seconds) that are not solved by configuring timeouts in the client * fix another hardcoded trio.sleep(1000)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.