Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put_block_list fails after removing the md5 feature. #1314

Closed
NickButcher1 opened this issue Jun 29, 2023 · 1 comment · Fixed by #1316
Closed

put_block_list fails after removing the md5 feature. #1314

NickButcher1 opened this issue Jun 29, 2023 · 1 comment · Fixed by #1316
Assignees

Comments

@NickButcher1
Copy link

I have dependencies on
azure_storage = "0.13.0"
azure_storage_blobs = {version = "0.13.0", features = ["md5"]}
azure_core = "0.13.0"

I have a working client which uploads blobs to Azure storage.

I want to remove the md5 feature (as now allowed by #1292), but when I do so, I see put_block_list requests fail with error "header not found content-md5". Note that put_block requests succeed.

I think I can see the bug:

API docs for put_block and put_block_list say that if I omit the content-md5 header from the request then it will also be omitted from the response.

But looking at the code I see:

  • PutBlockResponse.from_headers() allows for content_md5 to be optional.
  • PutBlockListResponse.from_headers() still requires content_md5 to be present. This is the bug.
@demoray demoray self-assigned this Jul 6, 2023
demoray pushed a commit to demoray/azure-sdk-for-rust that referenced this issue Jul 6, 2023
@demoray
Copy link
Contributor

demoray commented Jul 6, 2023

@NickButcher1 thanks for the report. azure_storage_blobs 0.13.1 should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants