Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create transport for Test Proxy #1876

Closed
heaths opened this issue Oct 24, 2024 · 0 comments · Fixed by #2033
Closed

Create transport for Test Proxy #1876

heaths opened this issue Oct 24, 2024 · 0 comments · Fixed by #2033
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. test-enhancement test-reliability Issue that causes tests to be unreliable

Comments

@heaths
Copy link
Member

heaths commented Oct 24, 2024

Maybe this is just our normal transport, but we should create the wiring necessary to hook it up either implicitly in integration tests (maybe via #[cfg(test)] attribute?) or make it really easy to do in integration tests like some sort of init() func to wire everything up (much like tracing subscribers).

@heaths heaths added Client This issue points to a problem in the data-plane of the library. test-enhancement test-reliability Issue that causes tests to be unreliable labels Oct 24, 2024
@heaths heaths self-assigned this Oct 24, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in Azure SDK Rust Oct 24, 2024
heaths added a commit to heaths/azure-sdk-for-rust that referenced this issue Jan 29, 2025
heaths added a commit to heaths/azure-sdk-for-rust that referenced this issue Jan 30, 2025
heaths added a commit to heaths/azure-sdk-for-rust that referenced this issue Feb 1, 2025
heaths added a commit that referenced this issue Feb 3, 2025
* Automatically record and play back test recordings

Resolves #1876

* Require `Result<T, E>` from recorded tests

This is simpler to support in the `#[recorded::test]` macro and sets a good precedent we want to show users anyway instead of `unwrap()` or `expect()`.

* Fix azure_core_test_macro tests

* Switch to multi-threaded async runtime and send correct headers

The default single-threaded async runtime runner was deadlocking in `Recording::drop()`. I opened #2049 to revisit this but I don't foresee any problem. We already don't support test-proxy on wasm32 and our mix of agents we do test on support multi-threaded async runtimes just fine.

* Fix Windows tests

* Safely log headers and body

We need to sanitize the headers later, but easier just to sanitize them all right now. This is still better than before which only showed how many headers were in the request.

* Fix regression to auto-start of test-proxy

* Resolve PR feedback
@github-project-automation github-project-automation bot moved this from Untriaged to Done in Azure SDK Rust Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. test-enhancement test-reliability Issue that causes tests to be unreliable
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant