add fn deserialize_null_as_default for deserializing JSON null values
#1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Oct 10, 2022
sdk/core/src/util.rs
Outdated
|
|
||
| /// Deserialize JSON null as default | ||
| /// https://github.com/serde-rs/serde/issues/1098 | ||
| pub fn deserialize_null_default<'de, D, T>(deserializer: D) -> Result<T, D::Error> |
There was a problem hiding this comment.
Nit: deserialize_null_as_default is ever so slightly clearer IMO
cataggar
changed the title
fn deserialize_null_default for deserializing JSON null valuesfn deserialize_null_as_default for deserializing JSON null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1113. This adds the workaround from serde-rs/serde#1098. I added unit tests and an example related to the fixed issue. No Azure services are supposed to return a JSON null when it is an array. This protects against those that do.
check all: https://github.com/ctaggart/azure-sdk-for-rust/actions/runs/3208461860