Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address lints from clippy 1.72.0 #1344

Merged
merged 4 commits into from
Aug 28, 2023
Merged

address lints from clippy 1.72.0 #1344

merged 4 commits into from
Aug 28, 2023

Conversation

demoray
Copy link
Contributor

@demoray demoray commented Aug 24, 2023

No description provided.

@demoray demoray requested review from cataggar and johnbatty August 24, 2023 23:02
Copy link
Contributor

@johnbatty johnbatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a shame we have to bump the minimum Rust version here - may make it harder for some people to take the update (although I'm fully in favour of keeping the Rust toolchain up to date, there will obviously be potential extra work/issues getting the toolchain updated).

I guess that's needed to be able to specify allow(clippy::<new lint name>)?

Is it possible to do something like this?

#[rustversion::since(1.70)]
#[allow(clippy::extra_unused_type_parameters)]

Then again, perhaps it is not worth this extra complication.

@demoray demoray merged commit c0d938c into Azure:main Aug 28, 2023
@demoray demoray deleted the clippy-1.72.0 branch August 28, 2023 12:49
@demoray
Copy link
Contributor Author

demoray commented Aug 28, 2023

@johnbatty the combination of one of the prereqs (that I don't recall at this time) bumping their minimum version as well as the new lint names, this was easier. I think for future clippy lints, we should consider your suggestion for future breaking lints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants