Support xml error respsonse #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlinio2000
requested review from
heaths,
RickWinter and
JeffreyRichter
as code owners
heaths
reviewed
Mar 28, 2024
merlinio2000
force-pushed
the
support-xml-error-respsonse
branch
from
b844756 to
8c83a17
Compare
merlinio2000
force-pushed
the
support-xml-error-respsonse
branch
from
5b55f97 to
ad3f688
Compare
merlinio2000
force-pushed
the
support-xml-error-respsonse
branch
from
593db29 to
02b0357
Compare
heaths
requested changes
Apr 2, 2024
Co-authored-by: Heath Stewart <heaths@outlook.com>
Co-authored-by: Heath Stewart <heaths@outlook.com>
Co-authored-by: Heath Stewart <heaths@outlook.com>
heaths
requested changes
Apr 16, 2024
This reverts commit a2f3b4b.
heaths
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1275
As mentioned in the issue for those places that only need the error code it would've been easier to get it from the headers but I'm unsure whether there are any case where this information is only provided through the body.
So to keep the current behavior I decided to keep parsing it from the body (now based on
content-typethough)If you think it would be alright to rely solely on the headers than I'd be happy to change that, it would remove a bit of code and prevent having to parse the body in some cases.
EDIT: Thanks to the all_tests script I discovered the issue of
quick-xmlbeing behind thexmlfeature flag.I see two options but don't know which one is better:
quick-xml/ remove thexmlfeaturexmlfeature (needs documentation)To quick fix for CI I will remove
quick-xmlfrom thexmlfeature for now. I'm thankful for any further guidance here