Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iothub device update by bumping api version to 2022-10-01 #1636

Merged
merged 4 commits into from
May 14, 2024

Conversation

JanZachmann
Copy link
Contributor

No description provided.

@JanZachmann JanZachmann changed the title chore: updated iothub device update api version to 2022-10-01 bump iothub device update api version to 2022-10-01 Apr 8, 2024
@JanZachmann
Copy link
Contributor Author

@microsoft-github-policy-service agree company="conplement ag"

@JanZachmann JanZachmann changed the title bump iothub device update api version to 2022-10-01 fix iothub device update by bumping api version to 2022-10-01 Apr 8, 2024
JanZachmann added a commit to JanZachmann/omnect-cli that referenced this pull request Apr 9, 2024
…te imports

switched from upstream azure-sdk-for-rust to omnect fork, which contains fixes and updates.
we should switch back if Azure/azure-sdk-for-rust#1636  is integrated.
JanZachmann added a commit to omnect/omnect-cli that referenced this pull request Apr 9, 2024
…te imports (#112)

Switched from upstream azure-sdk-for-rust to omnect fork, which contains
fixes and updates.
We should switch back if
Azure/azure-sdk-for-rust#1636 is integrated.
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you generate this via autorust, or hand edit? I think it's great that you're upgrading to the GA version, but OpenAPI definitions can change between preview and release (I see it all the time since I'm on the review board). I see you dropped some endpoints so maybe that is the case, but I wanted to double check.

sdk/iot_deviceupdate/src/client.rs Outdated Show resolved Hide resolved
@JanZachmann
Copy link
Contributor Author

Did you generate this via autorust, or hand edit? I think it's great that you're upgrading to the GA version, but OpenAPI definitions can change between preview and release (I see it all the time since I'm on the review board). I see you dropped some endpoints so maybe that is the case, but I wanted to double check.

It is hand edited. I just tried to fix the current incompatibility with current main. There are two issues:

  1. const API_VERSION: &str = "2021-06-01-preview"; isn't supported anymore
  2. endpoint changed

@JanZachmann JanZachmann requested a review from heaths April 28, 2024 18:42
sdk/iot_deviceupdate/src/client.rs Outdated Show resolved Hide resolved
@JanZachmann JanZachmann requested a review from heaths May 3, 2024 07:37
@heaths heaths enabled auto-merge (squash) May 14, 2024 18:06
@heaths heaths merged commit 33dc607 into Azure:main May 14, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants