Narrowly fix Test-Packages.ps1 and Analyze-Code.ps1 #3106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
RickWinter,
hallipr,
heaths and
weshaggard
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a temporary fix to improve error handling in PowerShell build scripts by adding explicit exit code checks after command execution. The changes ensure that failures in cargo commands and other build tools are properly detected and cause script termination.
Key changes:
- Replace direct
Invoke-LoggedCommandcalls with pattern that stores command in variable and checks$LastExitCode - Add
Write-Errorcalls when commands fail to ensure proper script termination - Apply consistent error handling pattern across multiple cargo operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/scripts/Test-Packages.ps1 | Added error checking for cargo build and test commands to ensure failures are properly handled |
| eng/scripts/Analyze-Code.ps1 | Added error checking for all cargo commands, rustup, and dependency verification scripts |
heaths
approved these changes
Oct 3, 2025
danieljurek
added a commit
that referenced
this pull request
Oct 6, 2025
This reverts commit 2cc1aec.
danieljurek
added a commit
that referenced
this pull request
Oct 7, 2025
This reverts commit 2cc1aec.
danieljurek
added a commit
that referenced
this pull request
Oct 7, 2025
Reverts #3106 Example failure (test and analyze failures expected): https://dev.azure.com/azure-sdk/public/_build/results?buildId=5418072&view=results Example success: https://dev.azure.com/azure-sdk/public/_build/results?buildId=5418071&view=results
Member
|
@danieljurek this shouldn't be the short-term fix this should be the real fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a short term fix. The longer term fix involves getting LogError to Write-Error
Analyze job failure: https://dev.azure.com/azure-sdk/public/_build/results?buildId=5413162&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9
Test jobs should also fail: https://dev.azure.com/azure-sdk/public/_build/results?buildId=5413162&view=logs&j=76992fd1-2312-5fae-7c45-7baba86b87ae