Pass package name from calling pipeline to uniquely identify pull req… (

#2046)

Currently file name is used to query API review document from cosmos DB within same PR. But .Net file path is different across each build due to generated version number for each build. This PR will submit a package name to API view to be used in query.

eng/common/scripts/Detect-Api-Changes.ps1

@@ -16,7 +16,7 @@ Param (
 )
 
 # Submit API review request and return status whether current revision is approved or pending or failed to create review
-function Submit-Request($filePath)
+function Submit-Request($filePath, $packageName)
 {
     $repoName = $RepoFullName
     if (!$repoName) {
@@ -29,6 +29,7 @@ function Submit-Request($filePath)
     $query.Add('commitSha', $CommitSha)
     $query.Add('repoName', $repoName)
     $query.Add('pullRequestNumber', $PullRequestNumber)
+    $query.Add('packageName', $packageName)
     $uri = [System.UriBuilder]$APIViewUri
     $uri.query = $query.toString()
     Write-Host "Request URI: $($uri.Uri.OriginalString)"
@@ -71,6 +72,7 @@ function Log-Input-Params()
     Write-Host "Language: $($Language)"
     Write-Host "Commit SHA: $($CommitSha)"
     Write-Host "Repo Name: $($RepoFullName)"
+    Write-Host "Package Name: $($PackageName)"
 }
 
 . (Join-Path $PSScriptRoot common.ps1)
@@ -95,7 +97,7 @@ foreach ($artifact in $ArtifactList)
         if (Should-Process-Package -pkgPath $pkgPath -packageName $artifact.name)
         {
             $filePath = $pkgPath.Replace($ArtifactPath , "").Replace("\", "/")
-            $respCode = Submit-Request -filePath $filePath
+            $respCode = Submit-Request -filePath $filePath -packageName $artifact.name
             if ($respCode -ne '200')
             {
                 $responses[$artifact.name] = $respCode
@@ -108,12 +110,7 @@ foreach ($artifact in $ArtifactList)
     }
 }
 
-if ($responses)
+foreach($pkg in $responses.keys)
 {
-    # Will update this with a link to wiki on how to resolve
-    Write-Warning "API change detection failed for following packages. Please check above for package level error details."
-    foreach($pkg in $responses.keys)
-    {
-        Write-Host "$pkg failed with $($responses[$pkg]) code"
-    }
+    Write-Host "API detection request status for $($pkg) : $($responses[$pkg])"
 }

src/dotnet/APIView/APIViewWeb/Controllers/PullRequestController.cs

@@ -30,14 +30,15 @@ public async Task<ActionResult> DetectApiChanges(
             string filePath, 
             int pullRequestNumber, 
             string commitSha,
-            string repoName)
+            string repoName,
+            string packageName)
         {
             if (!ValidateInputParams())
             {
                 return StatusCode(StatusCodes.Status400BadRequest);
             }
 
-            await _pullRequestManager.DetectApiChanges(buildId, artifactName, filePath, pullRequestNumber, commitSha, repoName);
+            await _pullRequestManager.DetectApiChanges(buildId, artifactName, filePath, pullRequestNumber, commitSha, repoName, packageName);
             return Ok();
         }
 

src/dotnet/APIView/APIViewWeb/Models/PullRequestModel.cs

@@ -17,5 +17,6 @@ public class PullRequestModel
         public bool IsOpen { get; set; } = true;
         public string ReviewId { get; set; }
         public string Author { get; set; }
+        public string PackageName { get; set; }
     }
 }

src/dotnet/APIView/APIViewWeb/Repositories/CosmosPullRequestsRepository.cs

@@ -19,9 +19,9 @@ public CosmosPullRequestsRepository(IConfiguration configuration)
             _pullRequestsContainer = client.GetContainer("APIView", "PullRequests");
         }
 
-        public async Task<PullRequestModel> GetPullRequestAsync(int pullRequestNumber, string repoName, string filePath)
+        public async Task<PullRequestModel> GetPullRequestAsync(int pullRequestNumber, string repoName, string packageName)
         {
-            var query = $"SELECT * FROM PullRequests c WHERE c.PullRequestNumber = {pullRequestNumber} and c.RepoName = '{repoName}' and c.FilePath = '{filePath}'";
+            var query = $"SELECT * FROM PullRequests c WHERE c.PullRequestNumber = {pullRequestNumber} and c.RepoName = '{repoName}' and c.PackageName = '{packageName}'";
             return await GetPullRequestFromQueryAsync(query);
         }
 

src/dotnet/APIView/APIViewWeb/Repositories/PullRequestManager.cs

@@ -60,14 +60,14 @@ IConfiguration configuration
         }
 
         // API change detection for PR will pull artifact from devops artifact
-        public async Task DetectApiChanges(string buildId, string artifactName, string filePath, int prNumber, string commitSha, string repoName)
+        public async Task DetectApiChanges(string buildId, string artifactName, string filePath, int prNumber, string commitSha, string repoName, string packageName)
         {
             var requestTelemetry = new RequestTelemetry { Name = "Detecting API changes for PR: " + prNumber };
             var operation = _telemetryClient.StartOperation(requestTelemetry);
             try
             {
                 string[] repoInfo = repoName.Split("/");
-                var pullRequestModel = await _pullRequestsRepository.GetPullRequestAsync(prNumber, repoName, filePath);
+                var pullRequestModel = await _pullRequestsRepository.GetPullRequestAsync(prNumber, repoName, packageName);
                 if (pullRequestModel == null)
                 {
                     var issue = await _githubClient.Issue.Get(repoInfo[0], repoInfo[1], prNumber);
@@ -76,7 +76,8 @@ public async Task DetectApiChanges(string buildId, string artifactName, string f
                         RepoName = repoName,
                         PullRequestNumber = prNumber,
                         FilePath = filePath,
-                        Author = issue.User.Login
+                        Author = issue.User.Login,
+                        PackageName = packageName
                     };
                 }
                 else