Include AzureSasCredential as allowed type for credential builder met…

…hod (#1360)
Azure · Feb 1, 2021 · 8505e8f · 8505e8f
1 parent cc8a11f
commit 8505e8f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...va-processor/src/main/java/com/azure/tools/apiview/processor/diagnostics/Diagnostics.java b/...va-processor/src/main/java/com/azure/tools/apiview/processor/diagnostics/Diagnostics.java
@@ -51,7 +51,8 @@ public Diagnostics() {
             .add("configuration", new ExactTypeNameCheckFunction("Configuration"))
             .add("clientOptions", new ExactTypeNameCheckFunction("ClientOptions"))
             .add("connectionString", new ExactTypeNameCheckFunction("String"))
-            .add("credential", new ExactTypeNameCheckFunction(new ParameterAllowedTypes("TokenCredential", "AzureKeyCredential")))
+            .add("credential", new ExactTypeNameCheckFunction(new ParameterAllowedTypes("TokenCredential",
+                    "AzureKeyCredential", "AzureSasCredential")))
             .add("endpoint", new ExactTypeNameCheckFunction("String"))
             .add("serviceVersion", new DirectSubclassCheckFunction("ServiceVersion")));
         diagnostics.add(new RequiredBuilderMethodsDiagnosticRule("amqp")

diff --git a/...azure/tools/apiview/processor/diagnostics/rules/RequiredBuilderMethodsDiagnosticRule.java b/...azure/tools/apiview/processor/diagnostics/rules/RequiredBuilderMethodsDiagnosticRule.java
@@ -98,7 +98,7 @@ public static class ExactTypeNameCheckFunction implements Function<MethodDeclara
         private final ParameterAllowedTypes[] expectedTypes;
 
         // For each parameter that we check for, we allow for there to be multiple types allowed for it,
-        // e.g. credential(TokenCredential) or credential(AzureKeyCredential)
+        // e.g. credential(TokenCredential) or credential(AzureKeyCredential) or credential(AzureSasCredential)
         public ExactTypeNameCheckFunction(ParameterAllowedTypes... expectedTypes) {
             this.expectedTypes = expectedTypes;
         }