Skip to content

Commit

Permalink
Batch eng/common changes to wrap-up #4888 work: NuGet package update,…
Browse files Browse the repository at this point in the history
… obsolete file deletion, test restoration (#4988)

#4988
  • Loading branch information
Konrad Jamrozik authored Dec 20, 2022
1 parent f88382d commit ed13cce
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 212 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ steps:
- script: >
dotnet tool install
Azure.Sdk.Tools.PipelineGenerator
--version 1.0.2-dev.20220504.1
--version 1.1.0-dev.20221216.2
--add-source https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json
--tool-path ${{parameters.ToolPath}}
workingDirectory: $(Pipeline.Workspace)/pipeline-generator
Expand Down
192 changes: 0 additions & 192 deletions eng/common/pipelines/templates/steps/prepare-pipelines.yml

This file was deleted.

2 changes: 1 addition & 1 deletion eng/common/scripts/get-codeowners.ps1
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
param (
[string]$TargetDirectory = "", # Code path to code owners. e.g sdk/core/azure-amqp
[string]$CodeOwnerFileLocation = (Resolve-Path $PSScriptRoot/../../../.github/CODEOWNERS), # The absolute path of CODEOWNERS file.
[string]$ToolVersion = "1.0.0-dev.20221005.1",
[string]$ToolVersion = "1.0.0-dev.20221215.1",
[string]$ToolPath = (Join-Path ([System.IO.Path]::GetTempPath()) "codeowners-tool-path"), # The place to check the tool existence. Put temp path as default
[string]$DevOpsFeed = "https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-for-net/nuget/v3/index.json", # DevOp tool feeds.
[string]$VsoVariable = "", # Option of write code owners into devop variable
Expand Down
26 changes: 8 additions & 18 deletions tools/code-owners-parser/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,11 @@ extends:
template: /eng/pipelines/templates/stages/archetype-sdk-tool-dotnet.yml
parameters:
ToolDirectory: tools/code-owners-parser
# As of 12/11/2022 temporarily disabling TestPostSteps because the
# get-codeowners.ps1 script uses the codeowners-parser NuGet package
# which has net5.0, not net6.0, which causes it to fail.
#
# For the failure details, please see:
# https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2048136&view=logs&j=f1c271e7-ab66-52b3-53cf-7a71849a1672&t=bbf61168-5c52-5848-16e1-d79919f292cd&l=14
#
# Work-item to re-enable this:
# https://github.com/Azure/azure-sdk-tools/issues/4938
#
# TestPostSteps:
# - task: PowerShell@2
# displayName: Test on code owner script
# inputs:
# pwsh: true
# filePath: eng/common/scripts/get-codeowners.ps1
# arguments: >
# -Test
TestPostSteps:
- task: PowerShell@2
displayName: Test on code owner script
inputs:
pwsh: true
filePath: eng/common/scripts/get-codeowners.ps1
arguments: >
-Test

0 comments on commit ed13cce

Please sign in to comment.