Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avocado] Make Avocado support permanent suppressions via config #6455

Closed
konrad-jamrozik opened this issue Jul 5, 2023 · 2 comments
Closed
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Jul 5, 2023

AutoRest plugins like LintDiff can be suppressed according to these instructions:

Avocado cannot be suppressed like that (i.e. via AutoRest config file, i.e. the README). It can only by be suppressed for given PR by adding Approved-Avocado label.

Avocado cannot be suppressed permanently as it is not an AutoRest plugin.

The Avocado call chain looks like that:

This work item is about making it possible to suppress Avocado permanently.

One possible way to solve this is to make Avocado read and interpret the AutoRest suppression syntax. Avocado is already reading the AutoRest config file (the README) as part of its implementation. This would require reimplementing the AutoRest suppression parsing logic, including json path parsing, inside Avocado.

@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Jul 5, 2023
@konrad-jamrozik konrad-jamrozik self-assigned this Jul 5, 2023
@konrad-jamrozik konrad-jamrozik changed the title Make Avocado support suppressions Make Avocado support permanent suppressions via config Jul 5, 2023
@konrad-jamrozik konrad-jamrozik changed the title Make Avocado support permanent suppressions via config [Avocado] Make Avocado support permanent suppressions via config Aug 18, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools Aug 18, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🚢🎉 Aug 18, 2023
@konrad-jamrozik
Copy link
Contributor Author

For example, multiple default tags error should be suppressed for Microsoft.Resources namespace. See this Teams thread.

@konrad-jamrozik
Copy link
Contributor Author

Delaying this item as we made Avocado non-blocking few months ago.

@konrad-jamrozik konrad-jamrozik closed this as not planned Won't fix, can't repro, duplicate, stale Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Spec PR Tools Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🎊 Closed in Azure SDK EngSys 🚢🎉 Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Archived in project
Status: 🎊 Closed
Development

No branches or pull requests

1 participant