Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retarget master as the base branch for docs metadata release #1109

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Retarget master as the base branch for docs metadata release #1109

merged 1 commit into from
Oct 23, 2020

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Oct 19, 2020

Have a PR submitted to the docs team that allows for non-conflicting commits. We can definitely get rid of smoke-test now.

Docs CI will also need to be updated, but that happens separately from this PR.

@scbedd scbedd requested a review from a team as a code owner October 19, 2020 23:02
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Oct 23, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
weshaggard
weshaggard reviewed Oct 23, 2020
View reviewed changes
eng/common/pipelines/templates/steps/docs-metadata-release.yml
PRBranchName: 'smoke-test-rdme'
SourceBranchName: 'smoke-test'
PRBranchName: 'master-rdme'
SourceBranchName: 'master'
PRLabels: 'auto-merge'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we were chatting yesterday this auto-merge label isn't being passed through to the second create-pull-request at the bottom of this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir. I'll do a follow-up.

@scbedd
Copy link
Member Author

scbedd commented Oct 23, 2020

Double checked that everything is g2g

image

Going to go through the merge processes now.

@ghost
Copy link

ghost commented Oct 23, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@scbedd
Copy link
Member Author

scbedd commented Oct 23, 2020

The sync is green, but the check didn't properly come back. I'm going to override and merge.

@scbedd
Copy link
Member Author

scbedd commented Oct 23, 2020

/check-enforcer override

@scbedd scbedd merged commit a714f99 into Azure:master Oct 23, 2020
benbp pushed a commit that referenced this pull request Dec 1, 2020
@scbedd @benbp
retarget master as the base branch for docs metadata release (#1109)
96ae2c1
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@ahsonkhan
Remove unused internal method since it has no callers: (Azure#1109)
7f24621 
'az_http_request_append_path'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@mitchdenny mitchdenny mitchdenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scbedd @azure-sdk @mitchdenny @weshaggard