Merged
Conversation
benbp
added
the
Central-EngSys
benbp
added
the
Central-EngSys
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the shebang line in a PowerShell script to use the more portable /usr/bin/env instead of /bin/env and improves the tool installation process by ensuring the destination directory exists before copying files.
- Updates shebang line from
#!/bin/env pwshto#!/usr/bin/env pwshfor better portability - Adds directory creation check before copying executable files
- Improves file path handling in the installation process
benbp
changed the title
scbedd
reviewed
Jul 25, 2025
scbedd
approved these changes
Jul 25, 2025
benbp
force-pushed
the
benbp/copilot-install-mac-fixes
branch
from
b399b82 to
889517c
Compare
scbedd
approved these changes
Jul 25, 2025
chrisradek
approved these changes
Jul 25, 2025
Member
chrisradek
left a comment
chrisradek
left a comment
There was a problem hiding this comment.
Tested on my mac and it works!
Collaborator
|
The following pipelines have been queued for testing: |
praveenkuttappan
approved these changes
Jul 25, 2025
weshaggard
approved these changes
Jul 25, 2025
This was referenced Jul 25, 2025
This was referenced Jul 25, 2025
azure-sdk
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Jul 25, 2025
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#11353 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like
/usr/bin/envis more conventional than/bin/envand not all users have the latter.