Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to purge all vaults, managed HSMs #1912

Merged
11 commits merged into from
Aug 18, 2021
Merged

Attempt to purge all vaults, managed HSMs #1912

11 commits merged into from
Aug 18, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Aug 16, 2021

Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.

Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
@heaths heaths requested a review from a team as a code owner August 16, 2021 21:51
@heaths heaths requested a review from weshaggard August 16, 2021 21:51
@heaths
Copy link
Member Author

heaths commented Aug 16, 2021

/azp run live-test-resource-cleanup

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -7,6 +7,18 @@ function Get-PurgeableGroupResources {
)
$purgeableResources = @()

# Discover Managed HSMs first since they are a premium resource.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be worth pushing this change to all the other repos but if you want to do it locally until we get through the list that is fine but I leave it up to you.

@heaths
Copy link
Member Author

heaths commented Aug 17, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@heaths
Copy link
Member Author

heaths commented Aug 17, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@heaths
Copy link
Member Author

heaths commented Aug 17, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Member Author

heaths commented Aug 17, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Member Author

heaths commented Aug 17, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.
@heaths
Copy link
Member Author

heaths commented Aug 17, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths heaths requested a review from danieljurek as a code owner August 18, 2021 02:43
@heaths heaths linked an issue Aug 18, 2021 that may be closed by this pull request
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@heaths
Copy link
Member Author

heaths commented Aug 18, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Member Author

heaths commented Aug 18, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@heaths
Copy link
Member Author

heaths commented Aug 18, 2021

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heaths
Copy link
Member Author

heaths commented Aug 18, 2021

I'm proceeding with the eng/common merge.

@ghost
Copy link

ghost commented Aug 18, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c23ca9d into main Aug 18, 2021
@ghost ghost deleted the keyvault-cleanup branch August 18, 2021 20:25
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeleteAfterHours=48 is too aggressive for local development
3 participants