Add latest released version to prepare prerelease #2130
Conversation
|
The following pipelines have been queued for testing: |
chidozieononiwu
force-pushed
the
UpdatePrepareRelease
branch
3 times, most recently
from
751236e to
fc45c61
Compare
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| Write-Host "Assuming release is in $month with release date $releaseDateString" -ForegroundColor Green | ||
| if (Test-Path "Function:GetExistingPackageVersions") |
There was a problem hiding this comment.
Instead of querying the package manager we should consider using the tags? If so we can move some of the tag helpers from https://github.com/Azure/azure-sdk/blob/main/eng/scripts/PackageVersion-Helpers.ps1#L3 into the tools repo.
There was a problem hiding this comment.
Isn't it possible for tags to exist for packages that eventually failed to publish to the package manager?
There was a problem hiding this comment.
Yes that is possible. I guess our package index script also verifies that the package link exists before it updates the package version. I wonder if we can just have a default implementation that uses the tags because that should be common and consistent across repos but allow for an override or verification for the versions.
There was a problem hiding this comment.
How about using this function but reverting to use the git tag where this function is not implemnted? Since it seems that this will be more reliable than git tag.
There was a problem hiding this comment.
I think eventually that might be reasonable but at this point since it is just for informational purposes in Prepare-release, it is probably not worth the effort. We can just not output this information if the function doesn't exist.
chidozieononiwu
force-pushed
the
UpdatePrepareRelease
branch
from
aa11f70 to
f327c4f
Compare
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Resolves #1608