Login and Pull docker image.

[sima-zhu]

Azure/azure-sdk-for-js#18405

Docs is switching the validation using docker container. Here is the common logic to pull image from Azure container register.

Testing pipeline in use with the script:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1172146&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739&t=bfb6cede-7671-5504-0a11-79b13ef63703

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[benbp]

Would it be simpler to structure the docker run steps via a container job, or is it done this way to make local+pipeline testing consistent?

[sima-zhu]

Would it be simpler to structure the docker run steps via a container job, or is it done this way to make local+pipeline testing consistent?

Will make a try. Thanks for helping explore more options.

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[weshaggard]

A container job will not help here because this is just one step in a larger job. A container job would only work if we wanted to run all the steps inside of that job, in this case the container is just a tool.

[sima-zhu]

A container job will not help here because this is just one step in a larger job. A container job would only work if we wanted to run all the steps inside of that job, in this case the container is just a tool.

Right, it did not bring too many benefits for moving all work into the container agent.
What's worse, if the docker is down, we expect to continue run the other jobs instead of killing all steps.

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[check-enforcer-staging]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[weshaggard]

This looks more along the lines of what I was expecting to see. Lets please be sure to test it out in your JS changes before merging this.

[danieljurek]

LGTM. If we were pulling multiple containers from the same source a docker login would be redundant but I don't think it'd be terribly detrimental.

[ghost]

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.