Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResourceType parameter #3457

Merged
1 commit merged into from
Jun 17, 2022
Merged

Add ResourceType parameter #3457

1 commit merged into from
Jun 17, 2022

Conversation

mikeharder
Copy link
Member

  • Selects live test or perf test resources

- Selects live test or perf test resources
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the changes, but I wonder if we should fall back to test-resources.* if perf-resources.* doesn't exist.

@@ -63,6 +63,10 @@ param (
[ValidateSet('AzureCloud', 'AzureUSGovernment', 'AzureChinaCloud', 'Dogfood')]
[string] $Environment = 'AzureCloud',

[Parameter()]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pain, but I believe the parameter docs (the comments here and the markdown files) also need to be updated. Though to be honest, given that we don't have great automation for this, I'm inclined to delete the markdown @heaths?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update the docs in a separate PR. I want to unblock the language repo perf test pipelines. And updating the docs is a little tricky since I'm trying to decide if I want to replace test-resources.json with test-resources.json or perf-resources.json, or something like $ResourceType-resources.json.

@mikeharder
Copy link
Member Author

@heaths: If you are OK with this as-is, can you please remove your "changes requested" review?

@ghost
Copy link

ghost commented Jun 17, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 5f17cc9 into Azure:main Jun 17, 2022
@mikeharder mikeharder deleted the test-resources-perf branch June 17, 2022 05:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants