-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResourceType parameter #3457
Conversation
mikeharder
commented
Jun 16, 2022
- Selects live test or perf test resources
- Selects live test or perf test resources
The following pipelines have been queued for testing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I like the changes, but I wonder if we should fall back to test-resources.* if perf-resources.* doesn't exist.
@@ -63,6 +63,10 @@ param ( | |||
[ValidateSet('AzureCloud', 'AzureUSGovernment', 'AzureChinaCloud', 'Dogfood')] | |||
[string] $Environment = 'AzureCloud', | |||
|
|||
[Parameter()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a pain, but I believe the parameter docs (the comments here and the markdown files) also need to be updated. Though to be honest, given that we don't have great automation for this, I'm inclined to delete the markdown @heaths?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update the docs in a separate PR. I want to unblock the language repo perf test pipelines. And updating the docs is a little tricky since I'm trying to decide if I want to replace test-resources.json
with test-resources.json or perf-resources.json
, or something like $ResourceType-resources.json
.
@heaths: If you are OK with this as-is, can you please remove your "changes requested" review? |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|