Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --no-cone in pipeline sparse checkout script #3606

Merged
1 commit merged into from
Jul 11, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented Jul 11, 2022

The latest update to git 2.37.0 adds cone and non-cone mode options explanation. In code mode, our previously used sparse checkout pattern filtering does not work, as the command expects directories instead. This PR updates our sparse checkout command to set --no-cone for no cone mode.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Jul 11, 2022
@benbp benbp self-assigned this Jul 11, 2022
Copy link
Contributor

@sima-zhu sima-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benbp benbp force-pushed the benbp/sparse-no-cone branch from e2bfec8 to 024e9cb Compare July 11, 2022 17:21
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Jul 11, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 057fd2c into Azure:main Jul 11, 2022
@benbp benbp deleted the benbp/sparse-no-cone branch July 11, 2022 17:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants