Update transition script to allow docker/podman usage #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te however, so all tests should be failing.
…re/docker-and-podman-transition
…e advantage of new breadcrumbs.
scbedd
changed the title
scbedd
commented
Oct 17, 2022
scbedd
commented
Oct 17, 2022
tools/test-proxy/scripts/transition-scripts/generate-assets-json.ps1
Outdated
Show resolved
Hide resolved
scbedd
commented
Oct 17, 2022
tools/test-proxy/scripts/transition-scripts/generate-assets-json.ps1
Outdated
Show resolved
Hide resolved
scbedd
commented
Oct 17, 2022
benbp
reviewed
Oct 17, 2022
benbp
reviewed
Oct 17, 2022
| ## Setup | ||
|
|
||
| Before running the script, understand that **only services that have migrated to use the `test-proxy` as their record/playback solution can store recordings into the external assets repository.** The CLI command commands are invoked from the `test-proxy` itself, so if it is NOT being used for record/playback, the work to transition to the `test-proxy` must be done before recordings can be moved. | ||
| Before running the script, understand that **only services that have migrated to use the `test-proxy` as their record/playback solution can store recordings into the external assets repository.** The test-proxy itself contains the code for `restoring`/`push`ing recordings, so if it is NOT being used for record/playback, that work must be completed before recordings can be moved. |
There was a problem hiding this comment.
I think the code blocks are confusing here, because restoring is not a test proxy verb. Maybe just remove them, or an alternative?
Suggested change
| Before running the script, understand that **only services that have migrated to use the `test-proxy` as their record/playback solution can store recordings into the external assets repository.** The test-proxy itself contains the code for `restoring`/`push`ing recordings, so if it is NOT being used for record/playback, that work must be completed before recordings can be moved. | |
| Before running the script, understand that **only services that have migrated to use the `test-proxy` as their record/playback solution can store recordings into the external assets repository.** The test-proxy itself contains the code for restoring/pushing recordings (`test-proxy [restore|push]`). If it is NOT being used for record/playback, that work must be completed before recordings can be moved. |
benbp
reviewed
Oct 17, 2022
benbp
reviewed
Oct 17, 2022
benbp
reviewed
Oct 17, 2022
benbp
reviewed
Oct 17, 2022
tools/test-proxy/scripts/transition-scripts/generate-assets-json.ps1
Outdated
Show resolved
Hide resolved
mccoyp
reviewed
Oct 17, 2022
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
benbp
reviewed
Oct 17, 2022
benbp
reviewed
Oct 17, 2022
benbp
approved these changes
Oct 17, 2022
…on.ps1 Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
….com/scbedd/azure-sdk-tools into feature/docker-and-podman-transition
|
/check-enforcer evaluate |
1 similar comment
|
/check-enforcer evaluate |
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4423 is required to merge before this does, hence draft. Resolves #4386
This PR updates the transition script to...
breadcrumbsare available now.dockerorpodmanfor their transition script run.TODO: