Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index table when generate service level readme #4632

Merged
6 commits merged into from
Nov 14, 2022
Merged

Update index table when generate service level readme #4632

6 commits merged into from
Nov 14, 2022

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Nov 4, 2022 •
edited
Loading

Python azure-developer-loadtesting package did not show up in preview page. After checkup, I found our index table is lack of ability of update.
Use the PR to fix the issue: #4646.

Also fixed the issue: #4002

Testing pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1971665&view=results

Service readme update: MicrosoftDocs/azure-docs-sdk-python@fa4a19f

Python load-testing preview service readme update: MicrosoftDocs/azure-docs-sdk-python@fa4a19f#diff-e72fa81fcf60a88d964ba37bab8f4118f8dff8b3db96758b98e20031796681e1

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu requested review from msyyc and benbp November 7, 2022 20:55
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu force-pushed the service_reamdme_fix branch from 26f6bb8 to 98d4359 Compare November 7, 2022 22:02
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu changed the title Update index table when generate service level readme [In testing phase]Update index table when generate service level readme Nov 7, 2022
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu changed the title [In testing phase]Update index table when generate service level readme Update index table when generate service level readme Nov 8, 2022
@kurtzeborn
Copy link
Member

While I see you're running this through the pipeline several times to validate that it works in an ad-hoc fashion, shouldn't you also have actual tests for this to be able to validate this again later when we come back to it for future changes?

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Nov 8, 2022 •
edited
Loading

While I see you're running this through the pipeline several times to validate that it works in an ad-hoc fashion, shouldn't you also have actual tests for this to be able to validate this again later when we come back to it for future changes?

I found the outputs are different if we ran the pipeline multiple times. I want to understand what happened there. My local test is fine before I found this. I have validated the behavior in local. But we need to run at least twice in pipeline to make sure the output are all as expected.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu force-pushed the service_reamdme_fix branch from cfe00d9 to 0d9e779 Compare November 8, 2022 20:10
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@kurtzeborn
Copy link
Member

While I see you're running this through the pipeline several times to validate that it works in an ad-hoc fashion, shouldn't you also have actual tests for this to be able to validate this again later when we come back to it for future changes?

I found the outputs are different if we ran the pipeline multiple times. I want to understand what happened there. My local test is fine before I found this. I have validated the behavior in local. But we need to run at least twice in pipeline to make sure the output are all as expected.

Shouldn't you also probably have a test script in addition to the ad-hoc testing you're doing? That way when someone comes back to this later, they'll have the tests you write to help them know they didn't break anything.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu requested a review from weshaggard November 10, 2022 00:36
@sima-zhu sima-zhu requested a review from a team as a code owner November 11, 2022 02:02
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

1 similar comment
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu force-pushed the service_reamdme_fix branch from 72c5f5f to 0013ccb Compare November 11, 2022 17:32
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@sima-zhu sima-zhu requested a review from danieljurek November 11, 2022 23:06
weshaggard
weshaggard approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the helpers script but otherwise looks good.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 14, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@sima-zhu sima-zhu force-pushed the service_reamdme_fix branch from 123601a to e6cd5f8 Compare November 14, 2022 20:28
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:

You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Nov 14, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2f50281 into Azure:main Nov 14, 2022
@sima-zhu sima-zhu deleted the service_reamdme_fix branch November 15, 2022 00:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@msyyc msyyc Awaiting requested review from msyyc

@benbp benbp Awaiting requested review from benbp

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sima-zhu @azure-sdk @kurtzeborn @benbp @weshaggard