-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add script for removing worm storage accounts #4959
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# Helper script for removing storage accounts with WORM that sometimes get leaked from live tests not set up to clean | ||
# up their resource policies | ||
|
||
[CmdletBinding(SupportsShouldProcess=$True)] | ||
param( | ||
[string]$GroupPrefix | ||
) | ||
|
||
# Be a little defensive so we don't delete non-live test groups via naming convention | ||
if (!$groupPrefix -or !$GroupPrefix.StartsWith('rg-')) { | ||
Write-Error "The -GroupPrefix parameter must start with 'rg-'" | ||
exit 1 | ||
} | ||
|
||
$groups = Get-AzResourceGroup | ? { $_.ResourceGroupName.StartsWith($GroupPrefix) } | ? { $_.ProvisioningState -ne 'Deleting' } | ||
|
||
foreach ($group in $groups) { | ||
Write-Host "=========================================" | ||
$accounts = Get-AzStorageAccount -ResourceGroupName $group.ResourceGroupName | ||
if ($accounts) { | ||
foreach ($account in $accounts) { | ||
if ($WhatIfPreference) { | ||
Write-Host "What if: Removing $($account.StorageAccountName) in $($account.ResourceGroupName)" | ||
} else { | ||
Write-Host "Removing $($account.StorageAccountName) in $($account.ResourceGroupName)" | ||
} | ||
$ctx = New-AzStorageContext -StorageAccountName $account.StorageAccountName | ||
$ctx | Get-AzStorageContainer | Get-AzStorageBlob | Remove-AzStorageBlob -Force | ||
# Use AzRm cmdlet as deletion will only work through ARM with the immutability policies defined on the blobs | ||
$ctx | Get-AzStorageContainer | % { Remove-AzRmStorageContainer -Name $_.Name -StorageAccountName $ctx.StorageAccountName -ResourceGroupName $group.ResourceGroupName -Force } | ||
Remove-AzStorageAccount -StorageAccountName $account.StorageAccountName -ResourceGroupName $account.ResourceGroupName -Force | ||
} | ||
} | ||
if ($WhatIfPreference) { | ||
Write-Host "What if: Removing resource group $($group.ResourceGroupName)" | ||
} else { | ||
Remove-AzResourceGroup -ResourceGroupName $group.ResourceGroupName -Force -AsJob | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the whatif logic in shouddprocess would already output this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to ship if whatif is set? I see you are still calling remove below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it up to just check
$WhatIfPreference
. The extra stuff from theShouldProcess
log makes the output hard to parse in my opinion.I still call Remove below because the parent
-WhatIf
will still pass through to the Az calls and I want those to be part of the whatif logging since it shows each container that would be deleted.