Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline-generator to use CommandLineParser #4969

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented Dec 14, 2022

I'm extending pipeline-generator to enable scenarios detailed in #2572. To do this, pipeline-generator will have multiple sub-commands:

pipeline-generator generate   # Current functionality, generate/sync pipelines from yaml files
pipeline-generator bootstrap  # (new) Create or update service principals and service connections for pipeline usage
pipeline-generator onboard    # (new) Set up keyvaults and/or access policies for new teams onboarding to Bring Your Own Subscription

As part of adding sub-command support, this PR updates the project to use CommandLineParser in line with our other C# CLI projects. I have also set up defaults for a lot of the common values to make local invocation much more concise, for example:

pipeline-generator generate --path /home/ben/sdk/azure-sdk-for-go/sdk -x go -d "\go" -r Azure/azure-sdk-for-go -c up -v 64 --set-managed-variables

After merge and tool release, I will put up a separate PR that includes the yaml config changes to call the tool correctly alongside the version bump.

@benbp benbp requested a review from weshaggard as a code owner December 14, 2022 23:57
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Dec 14, 2022
@benbp benbp self-assigned this Dec 14, 2022
@benbp benbp requested review from JimSuplizio and scbedd December 14, 2022 23:58
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@benbp
Copy link
Member Author

benbp commented Dec 15, 2022

/check-enforcer help

@github-actions
Copy link

For help using check enforcer, see https://aka.ms/azsdk/checkenforcer

Available commands:

  • /check-enforcer evaluate - Re-evaluate existing pipeline statuses for PR
  • /check-enforcer override - Ignore any pipeline missing or failed statuses for PR
  • /check-enforcer help - Add this comment

If you are initializing a new service, follow the new service docs. If no Azure Pipelines are desired, run /check-enforcer override.

@benbp benbp merged commit 4f6a9fd into Azure:main Dec 16, 2022
@benbp benbp deleted the benbp/pipeline-generator-cmdline branch December 16, 2022 20:01
ghost pushed a commit that referenced this pull request Dec 20, 2022
Updates the yaml to work with the new changes made in #4969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants