Make improvements to retrieve-codeowners tool: change accepted params (targetPath etc.) + refactor
#5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konrad-jamrozik
added
the
Central-EngSys
konrad-jamrozik
force-pushed
the
users/kojamroz/retrieve_tool_path
branch
2 times, most recently
from
9fe2f95 to
f784ccd
Compare
konrad-jamrozik
commented
Jan 11, 2023
| @@ -0,0 +1,115 @@ | |||
| using System; | |||
There was a problem hiding this comment.
FYI: this file was renamed from CodeOwnersFile but git didn't pick up on that.
konrad-jamrozik
changed the title
retrieve-codeowners toolretrieve-codeowners tool: change accepted params + refactor
konrad-jamrozik
changed the title
retrieve-codeowners tool: change accepted params + refactorretrieve-codeowners tool: change accepted params (targetPath etc.) + refactor
konrad-jamrozik
commented
Jan 11, 2023
| @@ -0,0 +1,58 @@ | |||
| using System.Collections.Generic; | |||
There was a problem hiding this comment.
FYI this file is renamed from MainTests.
konrad-jamrozik
force-pushed
the
users/kojamroz/retrieve_tool_path
branch
3 times, most recently
from
cde15ee to
a1e7fee
Compare
konrad-jamrozik
force-pushed
the
users/kojamroz/retrieve_tool_path
branch
from
8b5af31 to
3758b5a
Compare
weshaggard
reviewed
Jan 12, 2023
| string targetDirectory, | ||
| bool filterOutNonUserAliases = false | ||
| ) | ||
| string targetPath, |
There was a problem hiding this comment.
Just keep in mind that you will need to update places like https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/get-codeowners.ps1 when you update to the latest package version.
There was a problem hiding this comment.
@weshaggard yeah I already have a PR for that (in draft state as of now). Thanks for the reminder! :)
weshaggard
approved these changes
Jan 12, 2023
ghost
pushed a commit
that referenced
this pull request
Feb 16, 2023
…ers` executable + add some tests; make assorted refactorings (#5103) This PR is part of work required in preparation to merge: - #5088 Specifically, to enable review of ownership changes due to upcoming wildcards support, as explained in: - #5088 (comment) As such, this PR contributes to: - #2770 This PR is a prerequisite for following PRs: - #5431 ### Merging prerequisite This PR can be merged only after the following PRs are merged and relevant NuGet package published - #5437 - #5104 This is because this PR depends on that NuGet package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of work required in preparation to merge:
Specifically, to enable review of ownership changes due to upcoming wildcards support, as explained in:
As such, this PR contributes to:
Following PR depends on this one:
get-codeowners.ps1to work with the updatedRetrieveCodeOwnersexecutable + add some tests; make assorted refactorings #5103Changes made
All changes are within the scope of following paths:
/tools/code-owners-parser/**/tools/identity-resolutions/Services/GitHubService.cs/tools/notification-configurator/**Behavior changes:
RetrieveCodeOwners.Programnow accepts:targetPathinstead oftargetDirectoryexcludeNonUserAliasesinstead offilterOutNonUserAliasescodeownersFilePathOrUrlinstead ofcodeownersFilePathDebug.Assert(targetPath != null);precondition toCodeownersFile.GetMatchingCodeownersEntryInvalidOperationExceptionon case that should be impossible.Refactoring changes:
RetrieveCodeOwners.Program.[c|C]odeOwneroccurrences (except namespaces) to[c|C]odeowners. E.g.CodeOwnerEntrytoCodeownersEntry.MainTeststoProgramTeststo follow the test naming convention of<class>Testnot<method>Tests.CA*) warnings: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/IDE*) warnings: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/CodeownersFile.ProcessCodeownersLineorIsCommentLine.targetPathalways comes first, beforecodeownersEntries.Azure.Sdk.Tools.RetrieveCodeOwners.Tests.ProgramTests.