Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "npm ci" to install cspell and respect package-lock.json #5595

Merged
3 commits merged into from
Mar 3, 2023
Merged

Use "npm ci" to install cspell and respect package-lock.json #5595

3 commits merged into from
Mar 3, 2023

Conversation

danieljurek
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@mikeharder
Copy link
Member

If this fixes the issue, I approve, because npm ci is the more correct command anyway.

If this doesn't fix the issue, you might be hitting nodejs/node#46542, which is fixed in Node 18.14.2 (npm 9.5.0).

This was referenced Mar 2, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@danieljurek danieljurek mentioned this pull request Mar 2, 2023
Closed
@danieljurek
Copy link
Member Author

Example spell check working (rebased on eng/common sync PR) https://dev.azure.com/azure-sdk/public/_build/results?buildId=2601803&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=7b4713e3-e110-5049-e231-cc8a1e664c68

mikeharder
mikeharder requested changes Mar 2, 2023
View reviewed changes
eng/common/spelling/Invoke-Cspell.ps1 Outdated Show resolved Hide resolved
eng/common/spelling/Invoke-Cspell.ps1 Outdated Show resolved Hide resolved
eng/common/spelling/Invoke-Cspell.ps1 Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@mikeharder
Copy link
Member

LGTM

@danieljurek
Copy link
Member Author

Seeing this every time I try to get sync PRs opened...

,##[warning]There was a failure in sending the provision message: An unexpected failure occurred while attempting to contact the remote provider.

@danieljurek
Copy link
Member Author

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek
Copy link
Member Author

/azp run azure-sdk-tools - sync - eng-common

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@danieljurek danieljurek self-assigned this Mar 3, 2023
@danieljurek danieljurek added the Central-EngSys This issue is owned by the Engineering System team. label Mar 3, 2023
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 3, 2023
@azure-sdk @danieljurek
Sync eng/common directory with azure-sdk-tools for PR 5595 (#25064)
0d7c054 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#5595 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
@ghost
Copy link

ghost commented Mar 3, 2023

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit da16722 into main Mar 3, 2023
@ghost ghost deleted the djurek/fix-cspell-pin branch March 3, 2023 15:30
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gearama gearama gearama approved these changes

@mikeharder mikeharder mikeharder approved these changes

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

Assignees

@danieljurek danieljurek

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@danieljurek @azure-sdk @mikeharder @weshaggard @gearama