Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump test proxy version #6518

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Bump test proxy version #6518

merged 3 commits into from
Jul 28, 2023

Conversation

billwert
Copy link
Contributor

@billwert billwert commented Jul 14, 2023 •
edited by scbedd
Loading

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp requested a review from scbedd July 14, 2023 20:35
scbedd
scbedd approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Sync PRs are creating now. We just need to ensure that we don't have any unexpected reds on those sync PRs.

This was referenced Jul 18, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
scbedd
scbedd requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Withdrawing approval, .NET tests turned up some hard breaking changes.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

benbp
benbp previously approved these changes Jul 26, 2023
View reviewed changes
benbp
benbp reviewed Jul 26, 2023
View reviewed changes
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking approval, accident

@benbp benbp self-requested a review July 26, 2023 18:19
@benbp benbp dismissed their stale review July 26, 2023 18:19

Revoking approval, accident

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

scbedd
scbedd approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I need to tackle the broken links from this, but it's g2g.

@scbedd scbedd merged commit 45d254f into Azure:main Jul 28, 2023
@scbedd scbedd mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scbedd scbedd scbedd approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billwert @azure-sdk @benbp @scbedd