-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS linter yml file to eng/common/pipelines #7251
Conversation
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#7251 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: James Suplizio <jasupliz@microsoft.com>
codeowners-linter.yml is going to be the pipeline yml file that'll run the linter. This is a unique pipeline in that it's the only yml file in eng/common that is a fully contained pipeline instead of a template that's included in other pipelines. This needs to be in common because, like github-actions, it needs to set the version of the CodeownersLinter to install in a common place that gets pushed out to the other repositories.
Because the trigger is set to none, this shouldn't get picked up by pipeline generation which is we want. Once this is pushed out to the other repositories I'll need to do the following:
CODEOWNERS_baseline_errors.txt - This is baseline of deduped existing errors. The pipeline uses the baseline file to filter out existing errors otherwise it would start out failing. The baseline file is effectively there to prevent further bleeding but wouldn't prevent the same error from being added again (the unfortunate side effect of having to dedupe since we can't actually rely on errors per line number for obvious reasons).