Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS linter yml file to eng/common/pipelines #7251

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

JimSuplizio
Copy link
Member

codeowners-linter.yml is going to be the pipeline yml file that'll run the linter. This is a unique pipeline in that it's the only yml file in eng/common that is a fully contained pipeline instead of a template that's included in other pipelines. This needs to be in common because, like github-actions, it needs to set the version of the CodeownersLinter to install in a common place that gets pushed out to the other repositories.
Because the trigger is set to none, this shouldn't get picked up by pipeline generation which is we want. Once this is pushed out to the other repositories I'll need to do the following:

  1. Create their baseline files and get those checked in.
  2. Create the pipeline for that repository. The pipeline will run daily and the triggers are setup to run when there are changes to the CODEOWNERS or baseline files as part of PRs. Since the linter requires data that's produced as part of the pipeline-owners-extractor run, the pipelines will be scheduled to run daily after that pipeline runs (which is 4am PST).

CODEOWNERS_baseline_errors.txt - This is baseline of deduped existing errors. The pipeline uses the baseline file to filter out existing errors otherwise it would start out failing. The baseline file is effectively there to prevent further bleeding but wouldn't prevent the same error from being added again (the unfortunate side effect of having to dedupe since we can't actually rely on errors per line number for obvious reasons).

@JimSuplizio JimSuplizio added the CODEOWNERS Linter Anything related to the CODEOWNERS linter label Nov 7, 2023
@JimSuplizio JimSuplizio self-assigned this Nov 7, 2023
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Nov 8, 2023
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7251 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>
@JimSuplizio JimSuplizio merged commit 72073f2 into Azure:main Nov 8, 2023
7 checks passed
@JimSuplizio JimSuplizio deleted the LinterPipeline branch November 9, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CODEOWNERS Linter Anything related to the CODEOWNERS linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants