Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also write out an .env.sh file which can be safely be 'source'd into a shell. #7830

Closed
wants to merge 3 commits into from

Conversation

richardpark-msft
Copy link
Member

No description provided.

@richardpark-msft richardpark-msft marked this pull request as ready for review March 7, 2024 20:19
@richardpark-msft
Copy link
Member Author

CC: @LarryOsterman

@richardpark-msft richardpark-msft changed the title Also write out an .env.sh file which can be sourced easily into a shell. Also write out an .env.sh file which can be safely be 'source'd into a shell. Mar 15, 2024
Copy link

Hi @richardpark-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label May 17, 2024
@richardpark-msft
Copy link
Member Author

I just need to test this.

Copy link

Hi @richardpark-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Sep 13, 2024
Copy link

Hi @richardpark-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Sep 20, 2024
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Sep 20, 2024
@weshaggard
Copy link
Member

@richardpark-msft is this still interesting? Is there no way to avoid writing these secrets to disk?

@richardpark-msft
Copy link
Member Author

@richardpark-msft is this still interesting? Is there no way to avoid writing these secrets to disk?

They weren't necessarily secrets (for instance, one of the env variables is the endpoint you connect to, without any keys). However, the original reason the .env file wasn't source-able was because of connection strings, which have embedded '='s in them. Given our push away from those cred types, I think we can just drop this PR altogether!

@richardpark-msft richardpark-msft deleted the write-out-env-sh branch September 23, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants