-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also write out an .env.sh file which can be safely be 'source'd into a shell. #7830
Conversation
.../cluster/kubernetes/stress-test-addons/images/test-resource-deployer/test-resources-post.ps1
Outdated
Show resolved
Hide resolved
.../cluster/kubernetes/stress-test-addons/images/test-resource-deployer/test-resources-post.ps1
Show resolved
Hide resolved
CC: @LarryOsterman |
Hi @richardpark-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
I just need to test this. |
Hi @richardpark-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
Hi @richardpark-msft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
@richardpark-msft is this still interesting? Is there no way to avoid writing these secrets to disk? |
They weren't necessarily secrets (for instance, one of the env variables is the endpoint you connect to, without any keys). However, the original reason the .env file wasn't source-able was because of connection strings, which have embedded '='s in them. Given our push away from those cred types, I think we can just drop this PR altogether! |
No description provided.