Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create api review script changes to add a param to set release tag #7841

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Create api review script changes to add a param to set release tag #7841

merged 1 commit into from
Mar 18, 2024

Conversation

praveenkuttappan
Copy link
Member

Send a new param in request to APIView to tag a revision as released.

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Mar 7, 2024
@praveenkuttappan praveenkuttappan self-assigned this Mar 7, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@praveenkuttappan
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@praveenkuttappan
Copy link
Member Author

@weshaggard I have updated the common script to create API review using pregenerated token file as well as source artifact. Once it's merged, I will update python pipeline to use this common script instead of language repo specific script.

weshaggard
weshaggard approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small name changes. Otherwise looks good.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Mar 16, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk azure-sdk mentioned this pull request Mar 16, 2024
Merged
azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Mar 18, 2024
@azure-sdk @praveenkuttappan
Sync eng/common directory with azure-sdk-tools for PR 7841 (#28948)
3ca1200 
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7841 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>
@praveenkuttappan praveenkuttappan merged commit 373f1da into Azure:main Mar 18, 2024
12 checks passed
@praveenkuttappan praveenkuttappan deleted the tag_release_in_apiview branch March 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@konrad-jamrozik konrad-jamrozik Awaiting requested review from konrad-jamrozik

@benbp benbp Awaiting requested review from benbp

Assignees

@praveenkuttappan praveenkuttappan

Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
ApiView
Status: ✅ Done
Azure SDK EngSys 🚢🎉
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praveenkuttappan @azure-sdk @weshaggard