Fix sort ordering and type alias resolution #8438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort diagnostics and navigation slices. This requires a custom JSON marshaler for Navigation as it contains a map and the default behavior is non-deterministic. Recursively resolve type aliases. This is to handle cases where a type alias is to another type alias.
according to the docs, the keys *are* sorted
jhendrixMSFT
commented
Jun 13, 2024
chlowell
reviewed
Jun 13, 2024
jhendrixMSFT
commented
Jun 13, 2024
chlowell
approved these changes
Jun 13, 2024
|
@jhendrixMSFT I will sign-off for the codeowners requirement but I suggest adding an entry in the CODEOWNERS file for this tool for future approvals. |
weshaggard
approved these changes
Jun 13, 2024
|
@weshaggard I added appropriate code owners but the CI is flagging Charles' alias. Seems weird considering he's a listed code owner in the azure-sdk-for-go repo. |
|
@chlowell can you make your membership in Azure public? @jhendrixMSFT he is baselined in the go repo currently https://github.com/Azure/azure-sdk-for-go/blob/main/.github/CODEOWNERS_baseline_errors.txt#L1. Folks should be a public Azure member with write access. |
|
👍 have done |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run tools - codeowners-linter - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort diagnostics and navigation slices.
This requires a custom JSON marshaler for Navigation as it contains a map and the default behavior is non-deterministic.Per the docs, maps are sorted by key so we're ok here.Recursively resolve type aliases. This is to handle cases where a type alias is to another type alias.