[tsp-client] add combine-swaggers command #9017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2024 13:17
allenjzhang
reviewed
Sep 19, 2024
|
|
||
| const documents = []; | ||
| for (const file of swaggerFiles) { | ||
| if (!(await doesFileExist(file))) { |
There was a problem hiding this comment.
We should specify somewhere that this command only accepts the path to the swagger file and that we do not accept urls to a swagger since we do accept both in some commands.
| continue; | ||
| } | ||
|
|
||
| // when b value is null and any a value exists, ignore b value |
There was a problem hiding this comment.
Isnt this a regression if we add the value of a back into the combined swaggers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a quick and dirty
combine-swaggerscommand to 'merge' multiple swagger files into a single swagger file. This is meant to make it easier to compare existing APIs split across multiple files with a TypeSpec-generated API that exists in a single file.Only top-level fields are merged at this time, and no deduplication of array values is done.