Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APIView token TypeSpec to generate valid JSON schema with top… #9211

Merged

Conversation

praveenkuttappan
Copy link
Member

TypeSpec decorator changes and removed bundleId to generate single JSON schema with valid top level properties.

@praveenkuttappan praveenkuttappan added APIView Central-EngSys This issue is owned by the Engineering System team. labels Oct 17, 2024
@praveenkuttappan praveenkuttappan self-assigned this Oct 17, 2024
@JonathanGiles
Copy link
Member

I changed the URL in my parser validation code to point to the URL in this PR, and without changing any of my JSON (so it is very invalid), I got the following output:

Validation failed. Errors:
$.Language: must be the constant value 'C'
$.Language: must be the constant value 'C++'
$.Language: must be the constant value 'C#'
$.Language: must be the constant value 'Go'
$.Language: must be the constant value 'Java'
$.Language: must be the constant value 'JavaScript'
$.Language: must be the constant value 'Kotlin'
$.Language: must be the constant value 'Python'
$.Language: must be the constant value 'Swagger'
$.Language: must be the constant value 'Swift'
$.Language: must be the constant value 'TypeSpec'
$.LanguageVariant: must be the constant value 'None'
$.LanguageVariant: must be the constant value 'Spring'
$.LanguageVariant: must be the constant value 'Android'
$.Diagnostics[58]: required property 'TargetId' not found
$.Diagnostics[59]: required property 'TargetId' not found
$: required property 'ParserVersion' not found
$: required property 'ReviewLines' not found

So, I would say that this PR at the very least takes things in the right direction.

@praveenkuttappan praveenkuttappan merged commit 68f32a9 into Azure:main Oct 17, 2024
15 checks passed
@praveenkuttappan praveenkuttappan deleted the apiview_typespec_update branch October 17, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team.
Projects
Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants