Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support branch name with special char in create review step #9235

Merged

Conversation

praveenkuttappan
Copy link
Member

@praveenkuttappan praveenkuttappan commented Oct 22, 2024

Fix the issue in apiview pipeline step when branch name has &.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Oct 22, 2024
@praveenkuttappan praveenkuttappan self-assigned this Oct 22, 2024
@praveenkuttappan praveenkuttappan requested a review from a team as a code owner October 22, 2024 19:46
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

Change looks fine but what cases allow a space in the branch name?

@praveenkuttappan
Copy link
Member Author

Change looks fine but what cases allow a space in the branch name?

It's not space. It's & in the branch name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants