-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove a resolve-path from Get-PrPkgProperties
#9308
Conversation
The following pipelines have been queued for testing: |
What cases do we have where these files aren't on disk? Even without the resolve wouldn't that cause trouble? |
During EDIT: it looks like this when it blows up the way I'm resolving in this PR.
If it does, I am not seeing it. We're basically only using that However, it's unnecessary to add this Resolve-Path, as whatever directory path will be freshly generated on the same machine. This is just a straight up unnecessary piece of code that we're removing. |
This PR will enable PR invocations of
generate-job-matrix
won't crash when the files don't actually exist on disk.My only concern is the following scenario:
I have some FUD around a scenario where a
PkgProps
file is generated onwindows
and then we check-like PkgProps.DirectoryPath
against a path checked out on a different OS.