Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a resolve-path from Get-PrPkgProperties #9308

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 4, 2024

This PR will enable PR invocations of generate-job-matrix won't crash when the files don't actually exist on disk.

My only concern is the following scenario:

I have some FUD around a scenario where a PkgProps file is generated on windows and then we check -like PkgProps.DirectoryPath against a path checked out on a different OS.

@scbedd scbedd requested a review from a team as a code owner November 4, 2024 20:05
@scbedd scbedd self-assigned this Nov 4, 2024
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

What cases do we have where these files aren't on disk? Even without the resolve wouldn't that cause trouble?

@scbedd
Copy link
Member Author

scbedd commented Nov 4, 2024

What cases do we have where these files aren't on disk? Even without the resolve wouldn't that cause trouble?

During generate-job-matrix is where this breaks, because we use Get-PrPackageProperties to get the targeted set of packages + matrix configs.

EDIT: it looks like this when it blows up the way I'm resolving in this PR.

Even without the resolve wouldn't that cause trouble?

If it does, I am not seeing it. We're basically only using that Resolve-Path to ensure that the paths are all coherent for a platform. Not attempting to like a path/like/this with a path\\like\\this for instance.

However, it's unnecessary to add this Resolve-Path, as whatever directory path will be freshly generated on the same machine. This is just a straight up unnecessary piece of code that we're removing.

@scbedd scbedd merged commit a1bd217 into Azure:main Nov 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants