Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SemVer script #935

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Conversation

weshaggard
Copy link
Member

  • Change to beta instead of preview by default
  • Allow customization of default prerelease label
  • Allow customization of prerelease separators to support python version strings
  • Add sorting helpers

cc @chidozieononiwu @danieljurek

- Change to beta instead of preview by default
- Allow customization of default prerelease label
- Allow customization of prerelease separators to support python version strings
- Add sorting helpers
@@ -4,102 +4,244 @@ Parses a semver version string into its components and supports operations aroun

See https://azure.github.io/azure-sdk/policies_releases.html#package-versioning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This document does not yet reflect the beta convention for .NET and JS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is my PR Azure/azure-sdk#1536

@weshaggard
Copy link
Member Author

/check-enforcer reset

@weshaggard weshaggard merged commit 08fd25e into Azure:master Sep 1, 2020
@weshaggard weshaggard deleted the UpdateSemVerScript branch September 6, 2020 23:07
@ahsonkhan
Copy link
Contributor

ahsonkhan commented Sep 9, 2020

Change to beta instead of preview by default

Allow customization of prerelease separators to support python version strings

@weshaggard - could we have added an exemption for C as well, or waited for this change (if possible) until after this milestone's release?

We ended up having to workaround it for our final "preview" before GA: Azure/azure-sdk-for-c#1240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants