Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate JS Package #9511

Merged
merged 8 commits into from
Dec 26, 2024
Merged

Migrate JS Package #9511

merged 8 commits into from
Dec 26, 2024
+42 −3

Conversation

wanlwanl
Copy link
Member

Fix: #9510

@wanlwanl wanlwanl marked this pull request as ready for review December 13, 2024 06:12
@wanlwanl
Copy link
Member Author

Tested locally.
found 2 issues in migration tools.
Azure/azure-sdk-for-js#32202
Azure/azure-sdk-for-js#32200

@kazrael2119 Please help to test. in windows platform, you need to modify it as a workaround: https://github.com/Azure/azure-sdk-for-js/pull/32201/files#diff-b5c6091a6b6c3d41963de6bcb4443000186b55d3c8f76469ed31037cb29134fd

@qiaozha
Copy link
Member

qiaozha commented Dec 13, 2024

@mpodwysocki I wonder if we should wait for the migration command for samples update to be ready?

@wanlwanl
Copy link
Member Author

@qiaozha please note that there're 2 issues may need to fix by #9511 (comment). but I added a workaround, they won't impact us for now.

@wanlwanl wanlwanl enabled auto-merge (squash) December 13, 2024 06:29
@wanlwanl
Copy link
Member Author

@weshaggard could you help? I got the same issue twices recently

@wanlwanl
Copy link
Member Author

@chidozieononiwu, @mikeharder: could you please help me?

@qiaozha
Copy link
Member

qiaozha commented Dec 26, 2024

/check-enforcer override

@wanlwanl wanlwanl merged commit 4b6011d into main Dec 26, 2024
4 checks passed
@wanlwanl wanlwanl deleted the wanl/migrate-package branch December 26, 2024 02:57
@weshaggard
Copy link
Member

I've re-enabld the ci pipeline so it should trigger for future PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha qiaozha approved these changes

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate Packages of azure-sdk-for-js
4 participants
@wanlwanl @qiaozha @weshaggard @albertxavier100