Add Logging commands to common location #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
weshaggard
reviewed
Sep 9, 2020
chidozieononiwu
force-pushed
the
ExtendCommonPS1
branch
from
2c0ab63 to
7f2993e
Compare
chidozieononiwu
assigned azuresdkci, AutorestCI, azure-sdk, chidozieononiwu and weshaggard and unassigned azuresdkci, AutorestCI, azure-sdk, chidozieononiwu and weshaggard
weshaggard
reviewed
Sep 11, 2020
chidozieononiwu
force-pushed
the
ExtendCommonPS1
branch
from
7f2993e to
5664caa
Compare
weshaggard
reviewed
Sep 15, 2020
weshaggard
approved these changes
Sep 15, 2020
|
Looks like somehow the VerifyAndMerge step was skipped. Did you do something there or did it timeout? |
Yes. It timed out. |
|
/azp run azure-sdk-tools - sync - eng-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-tools
that referenced
this pull request
Dec 3, 2020
…tion for {u}int{32|64} parsing. (Azure#974)
* Limit use of sscanf only to double parsing, using a custom implementation
for {u}int{32|64} parsing.
* Add a few more atod test cases.
* Add explicit casts to avoid implicit conversion warnings.
* Fix bug where input is too small and add test cases.
* Address PR feedback - add and update comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logging functions to common location to enable reuse.