Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bug of missing title #999

Merged
merged 9 commits into from
Sep 15, 2020
Merged

Fixed the bug of missing title #999

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c48bfc
Fixed the bug of missing title
sima-zhu Sep 15, 2020
054490d
Added comments to make the call clear.
sima-zhu Sep 15, 2020
353b943
Remove extra title regex
sima-zhu Sep 15, 2020
81f28dc
Fixed the regex for both purpose
sima-zhu Sep 15, 2020
ee14881
Update eng/common/scripts/update-docs-metadata.ps1
sima-zhu Sep 15, 2020
daf84ed
remove commnets
sima-zhu Sep 15, 2020
ec58347
Merge branch 'Fix_bug_title' of https://github.com/sima-zhu/azure-sdk…
sima-zhu Sep 15, 2020
7bd7a3b
Fixed wrong var name
sima-zhu Sep 15, 2020
874c59b
Update eng/common/scripts/update-docs-metadata.ps1
sima-zhu Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions eng/common/scripts/update-docs-metadata.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,15 @@ function GetAdjustedReadmeContent($pkgInfo, $lang){
}

$fileContent = $pkgInfo.ReadmeContent
weshaggard marked this conversation as resolved.
Show resolved Hide resolved
$foundTitle = ""

# only replace the version if the formatted header can be found
$titleRegex = "(\# Azure .+? (?:client|plugin|shared) library for (?:JavaScript|Java|Python|\.NET|C))"
$fileContent = $pkgInfo.ReadmeContent -replace $titleRegex, "`${1} - Version $($pkgInfo.PackageVersion) `n"

$titleRegex = "(\#\s+(?<filetitle>Azure .+? (?:client|plugin|shared) library for (?:JavaScript|Java|Python|\.NET|C)))"
sima-zhu marked this conversation as resolved.
Show resolved Hide resolved
$fileTitle = ""
if ($pkgInfo.ReadmeContent -match $titleRegex) {
sima-zhu marked this conversation as resolved.
Show resolved Hide resolved
sima-zhu marked this conversation as resolved.
Show resolved Hide resolved
$fileContent = $fileContent -replace $titleRegex, "`${0} - Version $($pkgInfo.PackageVersion) `n"
# The if block gurantee there is at least one match which starts with the format of "# Azure..."
sima-zhu marked this conversation as resolved.
Show resolved Hide resolved
$fileTitle = $matches["filetitle"]
}
# Replace github master link with release tag.
$ReplacementPattern = "`${1}$($pkgInfo.Tag)"
$fileContent = $fileContent -replace $releaseReplaceRegex, $ReplacementPattern
Expand Down