Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS release notes for June #1386

Merged
merged 16 commits into from
Jun 17, 2020
Merged

Conversation

jeremymeng
Copy link
Member

No description provided.

@jeremymeng jeremymeng force-pushed the js-2020-june-relnotes branch from cce019e to eade7f5 Compare June 3, 2020 19:42
releases/2020-06/js.md Outdated Show resolved Hide resolved
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>

#### Key Bug Fixes

- Fixed an issue where a `TypeError` was sometimes thrown as an uncaught exception.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chradek Am thinking a generic statement on connection reliability should be good enough?

releases/2020-06/js.md Outdated Show resolved Hide resolved

#### Preview

- _Add packages_

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the GA release of Text Analytics.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willmtemple other languages list both preview.5 and GA. Should we do that? Feel free to submit suggestion if needed.

releases/2020-06/js.md Outdated Show resolved Hide resolved
releases/2020-06/js.md Outdated Show resolved Hide resolved
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
jeremymeng and others added 2 commits June 5, 2020 23:03
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>

#### Breaking Changes

- TODO
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a breaking change coming in for Identity:

  • Switch to using CredentialUnavailable to differentiate from expected and unexpected errors during DefaultAzureCredential startup. PR #8172. Note: this changes the original behavior for ManagedIdentityCredential, which previously would return null instead of throwing an exception.


#### New Features

- TODO
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Switch to using CredentialUnavailable to differentiate from expected and unexpected errors during DefaultAzureCredential startup. PR #8172

  • Make all developer credentials public as well as the list used by DefaultAzureCredential PR #9274

service bus

Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
releases/2020-06/js.md Outdated Show resolved Hide resolved
releases/2020-06/js.md Outdated Show resolved Hide resolved
jeremymeng and others added 2 commits June 9, 2020 23:54
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
@jeremymeng
Copy link
Member Author

@ramya-rao-a and team, any additional feedbacks?

@ramya-rao-a
Copy link
Contributor

Generic feedback not on this PR specifically and something to check with @adrianhall

Should we change the header Breaking changes to Breaking changes from last preview which would sound less alarming?

Also, we do call out in the beginning whether something is a preview or a bug fix over a GA. But, people who would generally skip the initial wall of text and go to the headers would have nothing in the individual section telling them whether it is a preview or not.

Can we consider a standard one liner below each service that says whether it is a first time GA, a preview or a bug fix release?

@ramya-rao-a
Copy link
Contributor

Another generic feedback:

Can we have "New features" appear before "Breaking changes"? As a user, it is nice to first be enticed with new features that would convince me whether to upgrade or not than looking at breaking changes

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 15, 2020

Nevermind, logged #1448

change to "Breaking Changes from Last Preview"
@jeremymeng jeremymeng merged commit b2bff4a into Azure:master Jun 17, 2020
@jeremymeng jeremymeng deleted the js-2020-june-relnotes branch June 17, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants