Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mssindhurid azure sdk js #2252

Closed
wants to merge 11 commits into from

Conversation

mssindhurid
Copy link
Contributor

Initial release of azure-security-attestation Beta version for JS

@mssindhurid
Copy link
Contributor Author

#sign-off

@mssindhurid
Copy link
Contributor Author

@xiangyan99 - Can you please review this PR and merge if approved

Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- Major changes only!
- Initial release of attestation Beta version to support data-plane operations of Microsoft Azure Attestation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: Initial release of Microsoft Azure Attestation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czubair - updated per feedback

@sadasant
Copy link
Contributor

@mssindhurid can I move your changes to my PR? https://github.com/Azure/azure-sdk/pull/2240/files

@sadasant
Copy link
Contributor

I'll close this on favor of this other PR #2240

Please submit feedback on what I've added on PR #2240. If I end up merging that PR before we get your feedback, don't worry! Please make a new PR on top of my updates and message me, and I'll make sure the changes are taken in.

@sadasant sadasant closed this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants