Ensure that all CRDs define subresources: status #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthchr
requested review from
babbageclunk,
davefellows,
frodopwns,
jananivMS,
Porges,
theunrepentantgeek and
WilliamMortlMicrosoft
as code owners
theunrepentantgeek
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There was a bug in Kustomize which sometimes caused it to drop fields that were "empty" such as
Special notes for your reviewer:
Since right now we're using whatever version of Kustomize you have locally to generate these file (which we should change!-- see #1271). Make sure to update the version of Kustomize you're using to at least 3.8.3.
How does this PR make you feel:
